magus v0.4.3 is out. See what's new
¶ View markdown source · ✎ Suggest an edit
2 min read

repeated-marks

An advisory by default: it explains, and blocks nothing, on a run of question or exclamation marks in a review reply ("??", "!!", "?!").

What it catches

A run of question or exclamation marks in a review reply ("??", "!!", "?!").

Dimension

stance: the text reads as a verdict on a person, or as addressed to someone else. A finding is counted on the dimension of its rule, the cost it names to the reader.

Why

Repeated marks read as exasperation where one mark asks the same question. Measured 2026-10-10 over the AIDev review comments: 0.17 percent of 39639 written by people and 0.05 percent of 42076 written by bots. Code spans are masked, so an operator such as ?? passes. Measured 2026-10-11 over the adjudicated labeling round: 46.5% precision (20 of 43) before, 100% (20 of 20) after: every false positive was an operator or placeholder outside a code span, so a run set between spaces or brackets, or touching a word it opens ("!!hit", "!!NAME!!"), is left alone. Labeling round 3 measured 34 of 34, a lower bound of 0.90, which each graded finding weighs.

Default decision

The code is PRF8014. The decision depends on the kind of text judged:

Kind Default
review-summary advise
review-inline advise
review-reply advise

Changing it

A decisions table sets this rule to deny, advise or off, for everything judged or for the files a glob matches. Proofread reads the table from the file its -decisions flag names:

{
  "rules": {"repeated-marks": "deny"},
  "paths": {"blog/**": {"repeated-marks": "off"}}
}

rules applies to every file. A glob in paths applies to the files it matches, and the last match wins. A rule set to off never reports.

Seeing it

A finding names the rule, its code and the decision that applies, and links here:

{"rule": "repeated-marks", "code": "PRF8014", "decision": "advise", "url": "https://eli.gladman.cc/magus/reference/proofread/repeated-marks/"}

proofread rules prints this entry with every other rule's.

See also

proofreadrulesrepeated-marksadvise
Last updated (87041fca)
Earlier changes on this page (2)

Full history ↗ · Blame source ↗

Glossary

Op

A single tool-native command a target composes (long form: operation); the middle of the work hierarchy (Spell to Op to Target). Op in full.

CI

An ordinary target you compose yourself with ctx.needs; magus does not hardcode its stages. It is the anchor magus affected ci keys off, and ci strips the rw charm. CI in full.

Span

OpenTelemetry's name for one unit of work under a trace: a target execution, whose sub-operations are child spans. An output reference points at a span's captured output. Span in full.

Run

One target executing under one magus invocation, such as magus run test web or magus affected ci. A run keeps its captured output behind an output reference. Every magus run is a run whether or not any job asked for it; see Job for how the two relate. Run in full.

Advisor

One read-only check from the advice suite: it reads the changeset through magus and writes one titled section of findings. The same advisors run as a pull request comment in CI and inside magus diff --impact locally. Advisor in full.

Conventions

This page uses none of the site's convention markers. The full set is on the conventions page.