magus v0.4.3 is out. See what's new
¶ View markdown source · ✎ Suggest an edit
1 min read

long-thread

An advisory by default: it explains, and blocks nothing, on a review reply that is its author's fourth or later in a thread.

What it catches

A review reply that is its author's fourth or later in a thread.

Dimension

stance: the text reads as a verdict on a person, or as addressed to someone else. A finding is counted on the dimension of its rule, the cost it names to the reader.

Why

A long exchange in text reads as a stalemate to the people watching it, and a call settles it faster. It needs the thread length (--thread-length), and stays silent without it.

Default decision

The code is PRF8004. The decision depends on the kind of text judged:

Kind Default
review-summary advise
review-inline advise
review-reply advise

Changing it

A decisions table sets this rule to deny, advise or off, for everything judged or for the files a glob matches. Proofread reads the table from the file its -decisions flag names:

{
  "rules": {"long-thread": "deny"},
  "paths": {"blog/**": {"long-thread": "off"}}
}

rules applies to every file. A glob in paths applies to the files it matches, and the last match wins. A rule set to off never reports.

Seeing it

A finding names the rule, its code and the decision that applies, and links here:

{"rule": "long-thread", "code": "PRF8004", "decision": "advise", "url": "https://eli.gladman.cc/magus/reference/proofread/long-thread/"}

proofread rules prints this entry with every other rule's.

See also

proofreadruleslong-threadadvise
Last updated (29d8b3de)
Earlier changes on this page (1)

Full history ↗ · Blame source ↗

Glossary

Op

A single tool-native command a target composes (long form: operation); the middle of the work hierarchy (Spell to Op to Target). Op in full.

CI

An ordinary target you compose yourself with ctx.needs; magus does not hardcode its stages. It is the anchor magus affected ci keys off, and ci strips the rw charm. CI in full.

Advisor

One read-only check from the advice suite: it reads the changeset through magus and writes one titled section of findings. The same advisors run as a pull request comment in CI and inside magus diff --impact locally. Advisor in full.

Conventions

This page uses none of the site's convention markers. The full set is on the conventions page.